🤖 fix: make temp directory cleanup non-blocking for faster stream interruption #459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When interrupting a stream (especially on SSH), the UI experienced a noticeable delay of 500ms-2s before responding. The user would hit Ctrl+C/Escape but the UI would remain in "streaming" state for 1-2 seconds.
Root Cause
The delay occurred because stream interruption waited for
processingPromiseto complete before emitting thestream-abortevent. In thefinallyblock ofprocessStreamWithCleanup(), we were executing:For SSH runtimes, this meant:
Even with an empty directory, this SSH round-trip takes 500ms-2s, blocking the UI update.
Solution
Made the temp directory cleanup fire-and-forget using
voidpromise. The cleanup still happens (and errors are logged), but it no longer blocks the critical path for emitting thestream-abortevent.The change is safe because:
Testing
Verify with SSH workspace:
Generated with
cmux